Resolve "No noetic support"
Closes #34 (closed)
Merge request reports
Activity
assigned to @inigo.moreno
- Resolved by Iñigo Moreno i Caireta
This fails because industrial-ci legacy does not support noetic. @miguel.prada or @jon.azpiazu why are we using the legacy branch in gitlab-ci?
added 7 commits
-
3a492beb...4536c086 - 6 commits from branch
master
- a0e565ad - Merge remote-tracking branch 'origin/master' into 34-noetic-support
-
3a492beb...4536c086 - 6 commits from branch
- Resolved by Iñigo Moreno i Caireta
With the change of industrial_ci to master, this now works! Here you can see a successful noetic job for Dummy Application.
requested review from @jon.azpiazu
requested review from @miguel.prada and removed review request for @jon.azpiazu
- Resolved by Prada Sarasola, Miguel
Not strictly related (or yes), but the template name
.gitlab-industrial-ci-kinetic-with-rosinstall.yml
(note thekinetic
) has less and less sense.I suggest moving to a general
.gitlab-industrial-ci.yaml
. If I am not wrong, gitlab ci format now supports nested includes, so we could use that in the.gitlab-industrial-ci-kinetic-with-rosinstall.yml
to keep compatibility with already existing repos.
- Resolved by Prada Sarasola, Miguel
- Resolved by Iñigo Moreno i Caireta
- Resolved by Jon Azpiazu
Sorry for jumping in late, but I actually do not think you need to do this: !62 (e9d0e074)
I added the explicit exclusion rules for the kinetic job because there was a
when: always
rule. But otherwise you should not need to explicitly exclude all possible cases.
Btw you can use the linter included in Gitlab to simulate the behaviors without need to add branches and commits to existing repos.
E.g. https://git.code.tecnalia.com/tecnalia_robotics-public/gitlab_templates/-/ci/lint
requested review from @jon.azpiazu and removed review request for @miguel.prada