Skip to content
Snippets Groups Projects

Add rosdep rules for two manually uploaded packages

Closed Jon Azpiazu requested to merge add-packages into master
3 unresolved threads
1 file
+ 8
0
Compare changes
  • Side-by-side
  • Inline
@@ -8,6 +8,10 @@ libpcl-1.8.1:
@@ -8,6 +8,10 @@ libpcl-1.8.1:
ubuntu:
ubuntu:
xenial: [libpcl1.8.1]
xenial: [libpcl1.8.1]
 
libpcl-1.9.1:
 
ubuntu:
 
xenial: [libpcl1.9.1]
 
peak:
peak:
ubuntu: [libpeak-dev]
ubuntu: [libpeak-dev]
@@ -134,3 +138,7 @@ rcobjectdetection_shape_thomas:
@@ -134,3 +138,7 @@ rcobjectdetection_shape_thomas:
rc_cv_utils:
rc_cv_utils:
ubuntu:
ubuntu:
xenial: [ros-kinetic-rc-cv-utils]
xenial: [ros-kinetic-rc-cv-utils]
 
 
vtk_7.1:
    • It would help avoid confusion if this was named vtk-7.1, since all existing rosdep rules use hyphens instead of underscores.

      • I'd say it is a bit heterogeneous right now (e.g. libpcl-1.8.1 vs robotnik_base_hw_lib).

        For ROS packages at least, the rule is to use underscores in the rosdep key, and hyphens in the package name, which is what I was trying to follow.

        But it is quite chaotic already, so I leave it up to you.

      • The issue is that we're abusing the rosdep definitions for ROS packages, which are declared differently in the official rosdistro repo, right?

        I assume libvtk is not a ROS package, though, so I would go for vtk-7.1 as key, to be coherent with the non-ROS-package rosdep key naming convention.

        What do you think of separating ROS vs non-ROS (system?) dependency declarations into different files?

      • Looking at some examples at base.yaml, I'd go for libtk1.7. Rationale: there is already a libvtk, and in some other cases the version number is not separated for the package name itself (e.g. gstreamer1.0 or libzmq3-dev). Also the -dev suffix looks only useful if there is a separation between runtime and devel, which is not the case.

      • Sounds good to me.

      • Please register or sign in to reply
Please register or sign in to reply
 
ubuntu:
 
xenial: [libvtk-7.1]
Loading