Skip to content
Snippets Groups Projects

Resolve "Add clang format to the CI tests"

Merged Prada Sarasola, Miguel requested to merge 13-add-clang-format-to-the-ci-tests into master

Closes #13 (closed)

Edited by Prada Sarasola, Miguel

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jon Azpiazu
  • Jon Azpiazu
  • added 5 commits

    • f768ff9d - Explicitly add wget in case it's removed from base image
    • 161cb6bc - Add comment to clang-format file pointing to its source
    • 17e9951c - Run clang-format job for tags as well
    • 51687632 - Force specific version of clang-format (3.8, default in Xenial)
    • 7692a7a0 - Enable clang-format job for melodic-devel branch

    Compare with previous version

  • Prada Sarasola, Miguel resolved all threads

    resolved all threads

  • Thanks for the comments!

  • Some minor suggestions:

    • do not wget in the .industrial_ci job, as it forces to download for every CI job when it is not really needed
    • in the same spirit, do not extend from the .industrial_ci job: we are forcing to login to artifactory even if it is not needed. I do not see a clear benefit of extending for this case.
    • I am not sure if it is possible, but use a smaller image - it is currently using ubuntu:xenial when probably alpine is enough.
  • added 1 commit

    • dc90b463 - Make clang_format job not to extend .industrial_ci

    Compare with previous version

  • Addressed two of your last comments in dc90b463.

    W/respect of using a smaller base image, alpine will not work because the clang-format check uses apt-get to download its dependencies. Maybe there's some smaller ubuntu or debian-based image that may work, but I'm honestly not very excited to spend time on this.

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading