Resolve "Add clang format to the CI tests"

Closes #13 (closed)

added 1 commit

• 72c07f0a - Add clang-format test for C++ code

Compare with previous version

added 1 commit

• d9684853 - Add clang-format test for C++ code

Compare with previous version

added 2 commits

• e487ed27 - Run clang-format check in 'postcheck' stage
• 71722772 - Only clone clang-format config file in relevant job

Compare with previous version

added 1 commit

• dd422494 - Temporarily run clang-format in precheck stage for faster iteration

Compare with previous version

added 1 commit

• 3d3e4d66 - Revert "Only clone clang-format config file in relevant job"

Compare with previous version

added 2 commits

• a3012bd2 - Revert "Temporarily run clang-format in precheck stage for faster iteration"
• ddd2016c - Point to master branch when retrieving clang-format config

Compare with previous version

I think the clang-format check is ready.

I decided to add the wget command fetching the formatting configuration in the .industrial_ci template, which isn't ideal. Adding it in the specific job requires repeating the other before_script steps, because they are otherwise overwritten.

I also left the except: melodic-devel flag because in my own repos I found out that the default version of clang-format which is installed in xenial and bionic have slightly different behaviors and jobs that pass in one distro may fail in the other.

Anyways, a couple of jobs showing the job in action: one where the check succeeds and other where the check fails.

After those jobs I pushed two new commits:

• moving the job to the postcheck stage (it was faster to iterate having it in the precheck stage)
• wget-ing the clang-format config file from master, in praparation to merge

What do you think?

unmarked as a Work In Progress

assigned to @jon.azpiazu

added 5 commits

• f768ff9d - Explicitly add wget in case it's removed from base image
• 161cb6bc - Add comment to clang-format file pointing to its source
• 17e9951c - Run clang-format job for tags as well
• 51687632 - Force specific version of clang-format (3.8, default in Xenial)
• 7692a7a0 - Enable clang-format job for melodic-devel branch

Compare with previous version

resolved all threads

Thanks for the comments!

Here's a test job after the latest changes.

Some minor suggestions:

• do not wget in the .industrial_ci job, as it forces to download for every CI job when it is not really needed
• in the same spirit, do not extend from the .industrial_ci job: we are forcing to login to artifactory even if it is not needed. I do not see a clear benefit of extending for this case.
• I am not sure if it is possible, but use a smaller image - it is currently using ubuntu:xenial when probably alpine is enough.

added 1 commit

• dc90b463 - Make clang_format job not to extend .industrial_ci

Compare with previous version

Addressed two of your last comments in dc90b463.

W/respect of using a smaller base image, alpine will not work because the clang-format check uses apt-get to download its dependencies. Maybe there's some smaller ubuntu or debian-based image that may work, but I'm honestly not very excited to spend time on this.