fix: don’t evaluate versions during extract (#7802)

lib/manager/nuget/__snapshots__/extract.spec.ts.snap

@@ -154,7 +154,6 @@ Array [
     "datasource": "nuget",
     "depName": "Stateless",
     "depType": "nuget",
-    "skipReason": "not-a-version",
   },
   Object {
     "currentValue": "1.2.3",
@@ -183,51 +182,6 @@ Array [
 ]
 `;
 
-exports[`lib/manager/nuget/extract extractPackageFile() extracts package version dependency 1`] = `
-Array [
-  Object {
-    "currentValue": "4.5.0",
-    "datasource": "nuget",
-    "depName": "Autofac",
-    "depType": "nuget",
-  },
-]
-`;
-
-exports[`lib/manager/nuget/extract extractPackageFile() extracts registry URLs independently 1`] = `
-Object {
-  "deps": Array [
-    Object {
-      "currentValue": "4.5.0",
-      "datasource": "nuget",
-      "depName": "Autofac",
-      "depType": "nuget",
-      "registryUrls": Array [
-        "https://api.nuget.org/v3/index.json",
-        "https://example.org/one",
-      ],
-    },
-  ],
-}
-`;
-
-exports[`lib/manager/nuget/extract extractPackageFile() extracts registry URLs independently 2`] = `
-Object {
-  "deps": Array [
-    Object {
-      "currentValue": "4.5.0",
-      "datasource": "nuget",
-      "depName": "Autofac",
-      "depType": "nuget",
-      "registryUrls": Array [
-        "https://api.nuget.org/v3/index.json",
-        "https://example.org/two",
-      ],
-    },
-  ],
-}
-`;
-
 exports[`lib/manager/nuget/extract extractPackageFile() extracts all dependencies from global packages file 1`] = `
 Array [
   Object {
@@ -307,7 +261,6 @@ Array [
     "datasource": "nuget",
     "depName": "Stateless",
     "depType": "nuget",
-    "skipReason": "not-a-version",
   },
   Object {
     "currentValue": "1.2.3",
@@ -336,6 +289,51 @@ Array [
 ]
 `;
 
+exports[`lib/manager/nuget/extract extractPackageFile() extracts package version dependency 1`] = `
+Array [
+  Object {
+    "currentValue": "4.5.0",
+    "datasource": "nuget",
+    "depName": "Autofac",
+    "depType": "nuget",
+  },
+]
+`;
+
+exports[`lib/manager/nuget/extract extractPackageFile() extracts registry URLs independently 1`] = `
+Object {
+  "deps": Array [
+    Object {
+      "currentValue": "4.5.0",
+      "datasource": "nuget",
+      "depName": "Autofac",
+      "depType": "nuget",
+      "registryUrls": Array [
+        "https://api.nuget.org/v3/index.json",
+        "https://example.org/one",
+      ],
+    },
+  ],
+}
+`;
+
+exports[`lib/manager/nuget/extract extractPackageFile() extracts registry URLs independently 2`] = `
+Object {
+  "deps": Array [
+    Object {
+      "currentValue": "4.5.0",
+      "datasource": "nuget",
+      "depName": "Autofac",
+      "depType": "nuget",
+      "registryUrls": Array [
+        "https://api.nuget.org/v3/index.json",
+        "https://example.org/two",
+      ],
+    },
+  ],
+}
+`;
+
 exports[`lib/manager/nuget/extract extractPackageFile() handles NuGet.config without package sources 1`] = `
 Object {
   "deps": Array [

lib/manager/nuget/extract.ts

 import { XmlDocument } from 'xmldoc';
 import * as datasourceNuget from '../../datasource/nuget';
 import { logger } from '../../logger';
-import { SkipReason } from '../../types';
-import { get } from '../../versioning';
-import * as semverVersioning from '../../versioning/semver';
 import { ExtractConfig, PackageDependency, PackageFile } from '../common';
 import { DotnetToolsManifest } from './types';
 import { determineRegistries } from './util';
@@ -61,7 +58,6 @@ export async function extractPackageFile(
   config: ExtractConfig
 ): Promise<PackageFile | null> {
   logger.trace({ packageFile }, 'nuget.extractPackageFile()');
-  const versioning = get(config.versioning || semverVersioning.id);
 
   const registries = await determineRegistries(packageFile, config.localDir);
   const registryUrls = registries
@@ -109,9 +105,6 @@ export async function extractPackageFile(
     deps = extractDepsFromXml(parsedXml).map((dep) => ({
       ...dep,
       ...(registryUrls && { registryUrls }),
-      ...(!versioning.isVersion(dep.currentValue) && {
-        skipReason: SkipReason.NotAVersion,
-      }),
     }));
     return { deps };
   } catch (err) {

lib/manager/pub/__snapshots__/extract.spec.ts.snap

@@ -18,13 +18,11 @@ Object {
       "currentValue": null,
       "depName": "baz",
       "depType": "dependencies",
-      "skipReason": "not-a-version",
     },
     Object {
       "currentValue": null,
       "depName": "qux",
       "depType": "dependencies",
-      "skipReason": "not-a-version",
     },
     Object {
       "currentValue": "^0.1",

lib/manager/pub/extract.ts

 import { safeLoad } from 'js-yaml';
 import * as datasourceDart from '../../datasource/dart';
 import { logger } from '../../logger';
-import { SkipReason } from '../../types';
 import { PackageDependency, PackageFile } from '../common';
 
 function getDeps(
@@ -31,9 +30,6 @@ function getDeps(
     }
 
     const dep: PackageDependency = { ...preset, depName, currentValue };
-    if (!currentValue) {
-      dep.skipReason = SkipReason.NotAVersion;
-    }
 
     return [...acc, dep];
   }, []);