diff --git a/lib/manager/nuget/__snapshots__/extract.spec.ts.snap b/lib/manager/nuget/__snapshots__/extract.spec.ts.snap index 973804c3fb56a4904b59febe49a4b8f320fefd43..c03d7371467f4509dc62623b8a87e8b43577a51d 100644 --- a/lib/manager/nuget/__snapshots__/extract.spec.ts.snap +++ b/lib/manager/nuget/__snapshots__/extract.spec.ts.snap @@ -154,7 +154,6 @@ Array [ "datasource": "nuget", "depName": "Stateless", "depType": "nuget", - "skipReason": "not-a-version", }, Object { "currentValue": "1.2.3", @@ -183,51 +182,6 @@ Array [ ] `; -exports[`lib/manager/nuget/extract extractPackageFile() extracts package version dependency 1`] = ` -Array [ - Object { - "currentValue": "4.5.0", - "datasource": "nuget", - "depName": "Autofac", - "depType": "nuget", - }, -] -`; - -exports[`lib/manager/nuget/extract extractPackageFile() extracts registry URLs independently 1`] = ` -Object { - "deps": Array [ - Object { - "currentValue": "4.5.0", - "datasource": "nuget", - "depName": "Autofac", - "depType": "nuget", - "registryUrls": Array [ - "https://api.nuget.org/v3/index.json", - "https://example.org/one", - ], - }, - ], -} -`; - -exports[`lib/manager/nuget/extract extractPackageFile() extracts registry URLs independently 2`] = ` -Object { - "deps": Array [ - Object { - "currentValue": "4.5.0", - "datasource": "nuget", - "depName": "Autofac", - "depType": "nuget", - "registryUrls": Array [ - "https://api.nuget.org/v3/index.json", - "https://example.org/two", - ], - }, - ], -} -`; - exports[`lib/manager/nuget/extract extractPackageFile() extracts all dependencies from global packages file 1`] = ` Array [ Object { @@ -307,7 +261,6 @@ Array [ "datasource": "nuget", "depName": "Stateless", "depType": "nuget", - "skipReason": "not-a-version", }, Object { "currentValue": "1.2.3", @@ -336,6 +289,51 @@ Array [ ] `; +exports[`lib/manager/nuget/extract extractPackageFile() extracts package version dependency 1`] = ` +Array [ + Object { + "currentValue": "4.5.0", + "datasource": "nuget", + "depName": "Autofac", + "depType": "nuget", + }, +] +`; + +exports[`lib/manager/nuget/extract extractPackageFile() extracts registry URLs independently 1`] = ` +Object { + "deps": Array [ + Object { + "currentValue": "4.5.0", + "datasource": "nuget", + "depName": "Autofac", + "depType": "nuget", + "registryUrls": Array [ + "https://api.nuget.org/v3/index.json", + "https://example.org/one", + ], + }, + ], +} +`; + +exports[`lib/manager/nuget/extract extractPackageFile() extracts registry URLs independently 2`] = ` +Object { + "deps": Array [ + Object { + "currentValue": "4.5.0", + "datasource": "nuget", + "depName": "Autofac", + "depType": "nuget", + "registryUrls": Array [ + "https://api.nuget.org/v3/index.json", + "https://example.org/two", + ], + }, + ], +} +`; + exports[`lib/manager/nuget/extract extractPackageFile() handles NuGet.config without package sources 1`] = ` Object { "deps": Array [ diff --git a/lib/manager/nuget/extract.ts b/lib/manager/nuget/extract.ts index 43a9c2bf768f69618f13da6b208894e438ee8a0d..ca2ea845fb4559a498d67a9a6e0ded13edf5581c 100644 --- a/lib/manager/nuget/extract.ts +++ b/lib/manager/nuget/extract.ts @@ -1,9 +1,6 @@ import { XmlDocument } from 'xmldoc'; import * as datasourceNuget from '../../datasource/nuget'; import { logger } from '../../logger'; -import { SkipReason } from '../../types'; -import { get } from '../../versioning'; -import * as semverVersioning from '../../versioning/semver'; import { ExtractConfig, PackageDependency, PackageFile } from '../common'; import { DotnetToolsManifest } from './types'; import { determineRegistries } from './util'; @@ -61,7 +58,6 @@ export async function extractPackageFile( config: ExtractConfig ): Promise<PackageFile | null> { logger.trace({ packageFile }, 'nuget.extractPackageFile()'); - const versioning = get(config.versioning || semverVersioning.id); const registries = await determineRegistries(packageFile, config.localDir); const registryUrls = registries @@ -109,9 +105,6 @@ export async function extractPackageFile( deps = extractDepsFromXml(parsedXml).map((dep) => ({ ...dep, ...(registryUrls && { registryUrls }), - ...(!versioning.isVersion(dep.currentValue) && { - skipReason: SkipReason.NotAVersion, - }), })); return { deps }; } catch (err) { diff --git a/lib/manager/pub/__snapshots__/extract.spec.ts.snap b/lib/manager/pub/__snapshots__/extract.spec.ts.snap index 890b12bb617c357ce6b0da68a6649f4fc3229e07..ac7259c371119e1469149cde06bd8e145eff5143 100644 --- a/lib/manager/pub/__snapshots__/extract.spec.ts.snap +++ b/lib/manager/pub/__snapshots__/extract.spec.ts.snap @@ -18,13 +18,11 @@ Object { "currentValue": null, "depName": "baz", "depType": "dependencies", - "skipReason": "not-a-version", }, Object { "currentValue": null, "depName": "qux", "depType": "dependencies", - "skipReason": "not-a-version", }, Object { "currentValue": "^0.1", diff --git a/lib/manager/pub/extract.ts b/lib/manager/pub/extract.ts index 44098f1cf51f2240102e18fcadb26058e13fb965..73c98d364559edb99f980e748f4d985a4c0f4ded 100644 --- a/lib/manager/pub/extract.ts +++ b/lib/manager/pub/extract.ts @@ -1,7 +1,6 @@ import { safeLoad } from 'js-yaml'; import * as datasourceDart from '../../datasource/dart'; import { logger } from '../../logger'; -import { SkipReason } from '../../types'; import { PackageDependency, PackageFile } from '../common'; function getDeps( @@ -31,9 +30,6 @@ function getDeps( } const dep: PackageDependency = { ...preset, depName, currentValue }; - if (!currentValue) { - dep.skipReason = SkipReason.NotAVersion; - } return [...acc, dep]; }, []);