Resolve "Ddeploy job failing when enforcing labels"

Closes #52 (closed)

added 1 commit

• cad93d11 - Try disabling buildkit in enforce_labels

Compare with previous version

Don't want to block you from merging this if it's blocking your work, so feel free to merge if this fixes your problems.

But out of curiosity:

• Isn't not pulling the base image the default for docker build?
• What does BuildKit have to do with this?

Not sure, I'm trying to apply the solution I found in https://stackoverflow.com/questions/20481225/how-can-i-use-a-local-image-as-the-base-image-with-a-dockerfile

I've done some very quick tests locally and in my machine BuildKit does affect the pull behavior, but apparently only when specifying the image ID in the FROM field. That is:

• If I specify the image name it works with or without BuildKit.
• If I specify the image ID it only works with the legacy builder.

--pull=false doesn't seem to affect one way or another, I think that's the default anyways.

This MR fixed the issue I was having.

changed this line in version 3 of the diff

added 1 commit

• 0536cf0a - Allow changing branch from which pulling enforce_labels

Compare with previous version

marked this merge request as ready

added 1 commit

• b8e2011c - Remove unneeded pull=false

Compare with previous version

requested review from @miguel.prada

added 1 commit

• 54eb1a1e - Remove trailing whitespace

Compare with previous version

mentioned in merge request !84 (merged)

This message is printed when running a build with DOCKER_BUILDKIT=0.

DEPRECATED: The legacy builder is deprecated and will be removed in a future release.
            BuildKit is currently disabled; enable it by removing the DOCKER_BUILDKIT=0
            environment-variable.

Using the full image name instead of the ID seems to also fix the problem, even when using BuildKit, see !84 (merged).

See a related test job here (it fails because I hadn't realized there were more uses of DOCKER_ID, hopefully this other job "passes").

merged