Resolve "Support LFS in templates"

include:
  - project: tecnalia_robotics-public/gitlab_templates
    ref: 37-support-lfs-in-templates
    file: 
      - ci-templates/auto-rules/with-rosinstall/melodic-default.yml
      - ci-templates/lfs-pull.yml

If you see the test-job, it seems to be working: LFS is initialized on line 225 and the zip file is loaded in line 274. However, the job still fails with some connectivity issues:

Failed to fetch http://packages.ros.org/ros-testing/ubuntu/pool/main/r/ros-melodic-xmlrpcpp/ros-melodic-xmlrpcpp_1.14.12-1bionic.20210921.180110_amd64.deb  404  Not Found [IP: 64.50.233.100 80]

@jon.azpiazu do you know what is going on?

added 1 commit

78223b45 - Move ROS_REPO to main

Compare with previous version

resolved all threads

mentioned in issue #40 (closed)

added 1 commit

ed16c55e - Add documentation

Compare with previous version

added 1 commit

f06250ed - Fix example

Compare with previous version

marked this merge request as ready

requested review from @jon.azpiazu

LGTM

I see that the test job of the repo which has an upstream repo which uses LFS is working correctly.

merged

mentioned in commit 9deafef0

A bit late to the party again here, but shouldn't the BEFORE_INSTALL_DOWNSTREAM_DEPENDENCIES hook be defined here too, just for completeness sake?

I guess, I doubt any downstream would need LFS, but it is should be added for completeness.

Why is that? Say I want to add some downstream packages to test for regressions in the manipulation repo. Any package I add will certainly be internal and may depend on LFS stuff, right? Or am I completely missing your point?

But the downstream package will in theory only depend on the target package to do some tests. If the target package already downloads its LFS stuff, the downstream package should also be able to use it.

But what if the downstream package has LFS stuff of its own? For instance, a test demo package that needs to download some big navigation maps in order to run its tests or something like that?

Ah yes, that makes sense

created #41 (closed) to continue this discussion

Do we have any actual example of using downstream?

I don't think so, given that it's a new feature introduced by the industrial_ci branch change.

Do we have any actual example of using downstream?

I have at least one in a medrob repository. I find it quite useful to identify when you break something by changing the API (or even just behavior, if downstream packages have tests).

I don't think so, given that it's a new feature introduced by the industrial_ci branch change.

It's not a new feature. It's better implemented now, but this functionality has existed for quite a long time in the legacy version as well.

resolved all threads

mentioned in issue #41 (closed)

Resolve "Support LFS in templates"

Merge request reports

Activity