Resolve "Dockerfile lint fails"
Closes #31 (closed)
Merge request reports
Activity
added 1 commit
- 53e29aa1 - Allow multiple consecutive RUN instructions in Dockerfiles (hadolint DL3059)
requested review from @jon.azpiazu
Are you sure the best way to go is to ignore the rule? In this specific case, there are 4 consecutive
RUN
commands which just do one single operation - which is installing VSCode. Would it make sense to have a singleRUN
command?Anyway we might as well just delete that Dockerfile, I do not think anyone is using the resulting image.
I'm fine with deleting it. Are you sure nobody uses it for their devcontainers?
Yes, pretty sure.
Anyway, those two Dockerfiles are only used in the industrial_ci_kinetic_deploy , which I would declare deprecated in favor of the ddeploy tool. So I would take out both things, the Dockerfiles and the job itself.
We could ask in the Team's channel if anyone is using that job in case you feel safer that way (although we can always easily restore it otherwise).
mentioned in issue #38 (closed)
mentioned in commit 48d1fa62