Relax Docker test severity and fix remaining issues

.gitlab-ci.yml

@@ -3,12 +3,19 @@ shellcheck:
   script: 'shellcheck deploy/base/ros_entrypoint.bash scripts/*sh'
   allow_failure: yes
 
+# The ignored rules in hadolint checks are
+# DL3006 Always tag the version of an image explicitly
+#   One of the Dockerfiles uses a temporary image which isn't important to tag
+#   and the other uses a tagged image through an ARG, which apparently is not
+#   properly recognized.
+# DL3008 Pin versions in apt-get install
+#   A bit overkill
 dockerfiles:
   image: hadolint/hadolint:latest-debian
   script:
     - RET=0
-    - hadolint deploy/base/Dockerfile || RET=1
-    - hadolint deploy/dev/Dockerfile || RET=1
+    - hadolint --ignore DL3006 --ignore DL3008 deploy/base/Dockerfile || RET=1
+    - hadolint --ignore DL3006 --ignore DL3008 deploy/dev/Dockerfile || RET=1
     - exit $RET
   allow_failure: yes
 

deploy/base/Dockerfile

@@ -2,7 +2,7 @@ FROM industrial_ci_image
 
 RUN rm -rf /root/ici /root/src
 
-RUN apt-get update -qq && apt-get install -y -qq \
+RUN apt-get update -qq && apt-get install -y -qq --no-install-recommends \
   ros-kinetic-rosbash \
   && rm -rf /var/lib/apt/lists/*
 

deploy/dev/Dockerfile

 ARG APPLICATION_IMAGE
 FROM ${APPLICATION_IMAGE}
 
-RUN apt-get update -qq && apt-get install -y -qq \
+RUN apt-get update -qq && apt-get install -y -qq --no-install-recommends \
   apt-transport-https \
   curl \
-  libasound2
+  libasound2 \
+  && rm -rf /var/lib/apt/lists/*
 
+SHELL ["/bin/bash", "-o", "pipefail", "-c"]
 RUN curl https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor > microsoft.gpg \
   && mv microsoft.gpg /etc/apt/trusted.gpg.d/microsoft.gpg \
   && sh -c 'echo "deb [arch=amd64] https://packages.microsoft.com/repos/vscode stable main" > /etc/apt/sources.list.d/vscode.list'
 
-RUN apt-get update -qq && apt-get install -y -qq \
-  code
+RUN apt-get update -qq && apt-get install -y -qq --no-install-recommends \
+  code \
+  && rm -rf /var/lib/apt/lists/*
 
 RUN echo "alias code='code --user-data-dir /root'" >> /root/.bashrc