Merge branch '26-improve-script-checking' into 'master'

Resolve "Improve script checking"

Closes #26

See merge request !51

.gitlab-industrial-ci-kinetic-no-rosinstall.yml

@@ -105,18 +105,21 @@ python_syntax:
 
 ##########################################################
 ## Check for errors in bash/sh scripts
-## Uses https://github.com/cytopia/awesome-ci
+## Uses https://github.com/koalaman/shellcheck
 ##########################################################
 bash_syntax:
+  before_script:
+    - apk add --update shellcheck
   stage: postcheck
   script:
     - RET=0
-    - docker run -v ${PWD}:/ac cytopia/awesome-ci syntax-sh --path=/ac --extension=sh --ignore=.ci_config || RET=1
-    - docker run -v ${PWD}:/ac cytopia/awesome-ci syntax-bash --path=/ac --extension=bash --ignore=.ci_config || RET=1
+    - find . -type f -name '*.sh' -exec shellcheck -s sh {} + || RET=1
+    - find . -type f -name '*.bash' -exec shellcheck -s bash {} + || RET=1
     - exit $RET
   when: always
   tags:
     - docker
+  allow_failure: yes
 
 ##########################################################
 ## Check for errors in markdown files

.gitlab-industrial-ci-kinetic-with-rosinstall.yml

@@ -107,18 +107,21 @@ python_syntax:
 
 ##########################################################
 ## Check for errors in bash/sh scripts
-## Uses https://github.com/cytopia/awesome-ci
+## Uses https://github.com/koalaman/shellcheck
 ##########################################################
 bash_syntax:
+  before_script:
+    - apk add --update shellcheck
   stage: postcheck
   script:
     - RET=0
-    - docker run -v ${PWD}:/ac cytopia/awesome-ci syntax-sh --path=/ac --extension=sh --ignore=.ci_config || RET=1
-    - docker run -v ${PWD}:/ac cytopia/awesome-ci syntax-bash --path=/ac --extension=bash --ignore=.ci_config || RET=1
+    - find . -type f -name '*.sh' -exec shellcheck -s sh {} + || RET=1
+    - find . -type f -name '*.bash' -exec shellcheck -s bash {} + || RET=1
     - exit $RET
   when: always
   tags:
     - docker
+  allow_failure: yes
 
 ##########################################################
 ## Check for errors in markdown files