refactor: move lookupType out of qualifiers

lib/datasource/github/index.js

@@ -90,8 +90,8 @@ async function getDigest(config) {
  */
 
 async function getPkgReleases(purl) {
-  const { lookupName: repo, qualifiers } = purl;
-  const lookupType = qualifiers.lookupType || 'tags';
+  const { lookupName: repo } = purl;
+  const lookupType = purl.lookupType || 'tags';
   let versions;
   const cachedResult = await renovateCache.get(
     cacheNamespace,
@@ -102,7 +102,7 @@ async function getPkgReleases(purl) {
     return cachedResult;
   }
   try {
-    if (lookupType === 'release') {
+    if (lookupType === 'releases') {
       const url = `https://api.github.com/repos/${repo}/releases?per_page=100`;
       versions = (await ghGot(url, { paginate: true })).body.map(
         o => o.tag_name

lib/manager/bazel/extract.js

@@ -128,7 +128,7 @@ function extractPackageFile(content) {
       dep.depName = depName;
       dep.repo = parsedUrl.repo;
       dep.currentValue = parsedUrl.currentValue;
-      dep.purl = 'pkg:github/' + dep.repo + '?lookupType=release';
+      dep.purl = 'pkg:github/' + dep.repo + '?lookupType=releases';
       deps.push(dep);
     } else {
       logger.info(

lib/util/purl.js

@@ -41,6 +41,10 @@ function parse(input) {
       const [key, val] = qualifier.split('=');
       res.qualifiers[key] = val;
     });
+    if (res.qualifiers.lookupType) {
+      res.lookupType = res.qualifiers.lookupType;
+      delete res.qualifiers.lookupType;
+    }
   } else {
     res.qualifiers = {};
   }

test/datasource/github.spec.js

@@ -88,7 +88,7 @@ describe('datasource/github', () => {
       ];
       ghGot.mockReturnValueOnce({ headers: {}, body });
       const res = await datasource.getPkgReleases({
-        purl: 'pkg:github/some/dep?lookupType=release',
+        purl: 'pkg:github/some/dep?lookupType=releases',
       });
       expect(res).toMatchSnapshot();
       expect(res.releases).toHaveLength(2);

test/manager/bazel/__snapshots__/extract.spec.js.snap

@@ -90,7 +90,7 @@ Array [
 ",
     "depName": "io_bazel_rules_go",
     "depType": "http_archive",
-    "purl": "pkg:github/bazelbuild/rules_go?lookupType=release",
+    "purl": "pkg:github/bazelbuild/rules_go?lookupType=releases",
     "repo": "bazelbuild/rules_go",
   },
   Object {
@@ -107,7 +107,7 @@ Array [
 ",
     "depName": "bazel_skylib",
     "depType": "http_archive",
-    "purl": "pkg:github/bazelbuild/bazel-skylib?lookupType=release",
+    "purl": "pkg:github/bazelbuild/bazel-skylib?lookupType=releases",
     "repo": "bazelbuild/bazel-skylib",
   },
 ]

test/util/__snapshots__/purl.spec.js.snap

 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
+exports[`util/purl parse() parses github with lookupType 1`] = `
+Object {
+  "datasource": "github",
+  "lookupName": "abc/def",
+  "lookupType": "releases",
+  "qualifiers": Object {},
+}
+`;
+
 exports[`util/purl parse() parses namespaced npm 1`] = `
 Object {
   "datasource": "npm",

test/util/purl.spec.js

@@ -26,5 +26,8 @@ describe('util/purl', () => {
     it('parses npm with version and 2 qualifiers and subpath', () => {
       expect(parse('pkg:npm/foo@1.0.0?a=b&c=d#stop')).toMatchSnapshot();
     });
+    it('parses github with lookupType', () => {
+      expect(parse('pkg:github/abc/def?lookupType=releases')).toMatchSnapshot();
+    });
   });
 });