Skip to content
Snippets Groups Projects
Unverified Commit d8d3ea21 authored by Rhys Arkins's avatar Rhys Arkins Committed by GitHub
Browse files

fix: log packageRule when recommending matchDepX (#23216)

parent 8af5ca0a
No related branches found
No related tags found
No related merge requests found
......@@ -6,8 +6,9 @@ import { Matcher } from './base';
export class PackageNameMatcher extends Matcher {
override matches(
{ depName, packageName }: PackageRuleInputConfig,
{ matchPackageNames }: PackageRule
packageRule: PackageRule
): boolean | null {
const { matchPackageNames } = packageRule;
if (is.undefined(matchPackageNames)) {
return null;
}
......@@ -21,7 +22,7 @@ export class PackageNameMatcher extends Matcher {
if (matchPackageNames.includes(depName)) {
logger.once.warn(
{ packageName, depName },
{ packageRule, packageName, depName },
'Use matchDepNames instead of matchPackageNames'
);
return true;
......
......@@ -21,8 +21,9 @@ function matchPatternsAgainstName(
export class PackagePatternsMatcher extends Matcher {
override matches(
{ depName, packageName }: PackageRuleInputConfig,
{ matchPackagePatterns }: PackageRule
packageRule: PackageRule
): boolean | null {
const { matchPackagePatterns } = packageRule;
if (is.undefined(matchPackagePatterns)) {
return null;
}
......@@ -39,7 +40,7 @@ export class PackagePatternsMatcher extends Matcher {
}
if (matchPatternsAgainstName(matchPackagePatterns, depName)) {
logger.once.warn(
{ packageName, depName },
{ packageRule, packageName, depName },
'Use matchDepPatterns instead of matchPackagePatterns'
);
return true;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment