Skip to content
Snippets Groups Projects
Unverified Commit d4d0ec46 authored by Sergei Zharinov's avatar Sergei Zharinov Committed by GitHub
Browse files

refactor(http): Rename `gotRoutine` to `gotTask` (#18338)

parent 66f35c95
No related branches found
No related tags found
No related merge requests found
...@@ -62,7 +62,7 @@ function applyDefaultHeaders(options: Options): void { ...@@ -62,7 +62,7 @@ function applyDefaultHeaders(options: Options): void {
// `Buffer` in the latter case. // `Buffer` in the latter case.
// We don't declare overload signatures because it's immediately wrapped by // We don't declare overload signatures because it's immediately wrapped by
// `request`. // `request`.
async function gotRoutine<T>( async function gotTask<T>(
url: string, url: string,
options: GotOptions, options: GotOptions,
requestStats: Omit<RequestStats, 'duration' | 'statusCode'> requestStats: Omit<RequestStats, 'duration' | 'statusCode'>
...@@ -162,16 +162,22 @@ export class Http<Opts extends HttpOptions = HttpOptions> { ...@@ -162,16 +162,22 @@ export class Http<Opts extends HttpOptions = HttpOptions> {
// istanbul ignore else: no cache tests // istanbul ignore else: no cache tests
if (!resPromise) { if (!resPromise) {
const startTime = Date.now(); const startTime = Date.now();
const queueTask = (): Promise<Response<T>> => { const httpTask = (): Promise<Response<T>> => {
const queueDuration = Date.now() - startTime; const queueDuration = Date.now() - startTime;
return gotRoutine(url, options, { return gotTask(url, options, {
method: options.method ?? 'get', method: options.method ?? 'get',
url, url,
queueDuration, queueDuration,
}); });
}; };
const queue = getQueue(url); const queue = getQueue(url);
resPromise = queue?.add(queueTask) ?? queueTask(); const queuedTask = queue
? () => queue.add<Response<T>>(httpTask)
: httpTask;
resPromise = queuedTask();
if (options.method === 'get' || options.method === 'head') { if (options.method === 'get' || options.method === 'head') {
memCache.set(cacheKey, resPromise); // always set if it's a get or a head memCache.set(cacheKey, resPromise); // always set if it's a get or a head
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment