Skip to content
Snippets Groups Projects
Unverified Commit cdd9b44a authored by Sergei Zharinov's avatar Sergei Zharinov Committed by GitHub
Browse files

refactor: Use null-safe Boolean filtering (#14039)

* refactor: Use null-safe Boolean filtering

* Simplify and remove file
parent f0a1b64b
No related branches found
No related tags found
No related merge requests found
......@@ -292,12 +292,7 @@ async function addReleasesUsingHeadRequests(
}
function getReleasesFromMap(releaseMap: ReleaseMap): Release[] {
const releases: Release[] = [];
for (const release of Object.values(releaseMap)) {
if (release) {
releases.push(release);
}
}
const releases = Object.values(releaseMap).filter(is.truthy);
if (releases.length) {
return releases;
}
......
......@@ -151,13 +151,10 @@ export function find(search: HostRuleSearch): HostRule {
}
export function hosts({ hostType }: { hostType: string }): string[] {
const result: string[] = [];
for (const rule of hostRules) {
if (rule.hostType === hostType && rule.resolvedHost) {
result.push(rule.resolvedHost);
}
}
return result;
return hostRules
.filter((rule) => rule.hostType === hostType)
.map((rule) => rule.resolvedHost)
.filter(is.truthy);
}
export function findAll({ hostType }: { hostType: string }): HostRule[] {
......
......@@ -109,17 +109,6 @@ export class RegExpVersioningApi extends GenericVersioningApi<RegExpVersion> {
);
}
private _getSemverVersions(versions: string[]): string[] {
const parsedVersions: string[] = [];
versions.forEach((v) => {
const parsedVersion = this._parse(v);
if (parsedVersion) {
parsedVersions.push(asSemver(parsedVersion));
}
});
return parsedVersions;
}
override getSatisfyingVersion(
versions: string[],
range: string
......@@ -127,7 +116,10 @@ export class RegExpVersioningApi extends GenericVersioningApi<RegExpVersion> {
const parsedRange = this._parse(range);
return parsedRange
? semver.maxSatisfying(
this._getSemverVersions(versions),
versions
.map((v) => this._parse(v))
.filter(is.truthy)
.map(asSemver),
asSemver(parsedRange)
)
: null;
......@@ -140,7 +132,10 @@ export class RegExpVersioningApi extends GenericVersioningApi<RegExpVersion> {
const parsedRange = this._parse(range);
return parsedRange
? semver.minSatisfying(
this._getSemverVersions(versions),
versions
.map((v) => this._parse(v))
.filter(is.truthy)
.map(asSemver),
asSemver(parsedRange)
)
: null;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment