fix: add try-catch to getFileList (#975)

lib/api/github.js

@@ -233,6 +233,7 @@ async function getFileList(branchName) {
   if (config.fileList) {
     return config.fileList;
   }
+  try {
     const res = await get(
       `repos/${config.repoName}/git/trees/${branchName}?recursive=true`
     );
@@ -246,6 +247,12 @@ async function getFileList(branchName) {
       .filter(item => item.type === 'blob')
       .map(item => item.path)
       .sort();
+  } catch (err) {
+    // TODO: change this from warn to info once we know exactly why it happens
+    logger.warn({ repository: config.repoName }, 'Error retrieving git tree');
+    config.fileList = [];
+  }
+
   return config.fileList;
 }
 

lib/api/gitlab.js

@@ -128,6 +128,7 @@ async function getFileList(branchName) {
   if (config.fileList) {
     return config.fileList;
   }
+  try {
     const res = await get(
       `projects/${config.repoName}/repository/tree?ref=${branchName}&recursive=true&per_page=100`,
       { paginate: true }
@@ -136,6 +137,10 @@ async function getFileList(branchName) {
       .filter(item => item.type === 'blob')
       .map(item => item.path)
       .sort();
+  } catch (err) {
+    logger.warn('Error retrieving git tree');
+    config.fileList = [];
+  }
   return config.fileList;
 }
 

test/api/github.spec.js

@@ -469,6 +469,16 @@ describe('api/github', () => {
       expect(get.mock.calls).toMatchSnapshot();
     });
   });
+  describe('getFileList', () => {
+    it('returns empty array if error', async () => {
+      await initRepo('some/repo', 'token');
+      get.mockImplementationOnce(() => {
+        throw new Error('some error');
+      });
+      const files = await github.findFilePaths('someething');
+      expect(files).toEqual([]);
+    });
+  });
   describe('findFilePaths(fileName)', () => {
     it('warns if truncated result', async () => {
       await initRepo('some/repo', 'token');

test/api/gitlab.spec.js

@@ -191,6 +191,14 @@ describe('api/gitlab', () => {
     });
   });
   describe('findFilePaths(fileName)', () => {
+    it('returns empty array if error', async () => {
+      await initRepo('some/repo', 'token');
+      get.mockImplementationOnce(() => {
+        throw new Error('some error');
+      });
+      const files = await gitlab.findFilePaths('someething');
+      expect(files).toEqual([]);
+    });
     it('warns if truncated result', async () => {
       await initRepo('some/repo', 'token');
       get.mockImplementationOnce(() => ({