Skip to content
Snippets Groups Projects
Commit ad3f8d94 authored by Rhys Arkins's avatar Rhys Arkins Committed by GitHub
Browse files

fix: wrap meteor parsing in try/catch (#921)

parent 393c24c6
Branches
Tags
No related merge requests found
......@@ -28,6 +28,7 @@ async function renovateDepType(packageContent, config) {
logger.debug(`deps length is ${deps.length}`);
logger.debug({ deps }, `deps`);
} else if (config.packageFile.endsWith('package.js')) {
try {
deps = packageContent
.match(/Npm\.depends\({([\s\S]*?)}\);/)[1]
.replace(/(\s|\\n|\\t|'|")/g, '')
......@@ -38,6 +39,9 @@ async function renovateDepType(packageContent, config) {
depName: arr[0],
currentVersion: arr[1],
}));
} catch (err) {
logger.warn({ packageContent }, 'Failed to parse meteor package.js');
}
} else if (config.packageFile.endsWith('Dockerfile')) {
const [imagetag, currentDigest] = config.currentFrom.split('@');
const [depName, currentTag] = imagetag.split(':');
......
......@@ -58,6 +58,12 @@ describe('lib/workers/dep-type/index', () => {
const res = await depTypeWorker.renovateDepType(content, config);
expect(res).toHaveLength(6);
});
it('handles malformed meteor', async () => {
config.packageFile = 'package.js';
const content = 'blah';
const res = await depTypeWorker.renovateDepType(content, config);
expect(res).toHaveLength(0);
});
it('returns upgrades for docker', async () => {
config.packageFile = 'Dockerfile';
config.currentFrom = 'node';
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment