Skip to content
Snippets Groups Projects
Commit a2fab232 authored by Rhys Arkins's avatar Rhys Arkins
Browse files

fix: raise config error issue for nested presets

parent cce92e4d
No related branches found
No related tags found
No related merge requests found
...@@ -28,8 +28,6 @@ async function resolveConfigPresets(inputConfig, existingPresets = []) { ...@@ -28,8 +28,6 @@ async function resolveConfigPresets(inputConfig, existingPresets = []) {
try { try {
fetchedPreset = await getPreset(preset); fetchedPreset = await getPreset(preset);
} catch (err) { } catch (err) {
// istanbul ignore else
if (existingPresets.length === 0) {
const error = new Error('config-validation'); const error = new Error('config-validation');
if (err.message === 'dep not found') { if (err.message === 'dep not found') {
error.validationError = `Cannot find preset's package (${preset})`; error.validationError = `Cannot find preset's package (${preset})`;
...@@ -44,12 +42,13 @@ async function resolveConfigPresets(inputConfig, existingPresets = []) { ...@@ -44,12 +42,13 @@ async function resolveConfigPresets(inputConfig, existingPresets = []) {
throw err; throw err;
} }
} }
// istanbul ignore if
if (existingPresets.length) {
error.validationError +=
'. Note: this is a *nested* preset so please contact the preset author if you are unable to fix it yourself.';
}
logger.info('Throwing preset error'); logger.info('Throwing preset error');
throw error; throw error;
} else {
logger.warn({ preset }, `Cannot find nested preset`);
fetchedPreset = {};
}
} }
const presetConfig = await resolveConfigPresets( const presetConfig = await resolveConfigPresets(
fetchedPreset, fetchedPreset,
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment