Skip to content
Snippets Groups Projects
Commit 8b761f5a authored by Rhys Arkins's avatar Rhys Arkins
Browse files

fix(gradle): throw registry failure if lookup fails

parent ff6115fb
No related branches found
No related tags found
No related merge requests found
......@@ -26,10 +26,7 @@ async function extractAllPackageFiles(config, packageFiles) {
}
await configureUseLatestVersionPlugin(config.localDir);
const gradleSuccess = await executeGradle(config);
if (!gradleSuccess) {
return null;
}
await executeGradle(config);
gradle.init();
const gradleFiles = [];
......@@ -171,11 +168,11 @@ async function executeGradle(config) {
logger.error(' Process killed. Possibly gradle timed out.');
}
logger.warn({ err }, errorStr);
return false;
logger.info('Aborting Renovate due to Gradle lookup errors');
throw new Error('registry-failure');
}
logger.debug(stdout + stderr);
logger.info('Gradle report complete');
return true;
}
function getDockerRenovateGradleCommandLine(localDir) {
......
......@@ -79,3 +79,5 @@ Array [
},
]
`;
exports[`manager/gradle extractPackageFile should throw registry failure if gradle execution fails 1`] = `[Error: registry-failure]`;
......@@ -52,15 +52,17 @@ describe('manager/gradle', () => {
expect(dependencies).toEqual([]);
});
it('should return null if gradle execution fails', async () => {
it('should throw registry failure if gradle execution fails', async () => {
exec.mockImplementation(() => {
throw new Error();
});
const dependencies = await manager.extractAllPackageFiles(config, [
'build.gradle',
]);
expect(dependencies).toEqual(null);
let e;
try {
await manager.extractAllPackageFiles(config, ['build.gradle']);
} catch (err) {
e = err;
}
expect(e).toMatchSnapshot();
});
it('should return empty if there is no dependency report', async () => {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment