fix: convert for loop to for..of (#915)

* fix: convert for loop to for..of

* chore: lessen preset debugging

* chore: set detectPackageFiles to debug

* fix lint

lib/config/presets.js

@@ -22,13 +22,15 @@ async function resolveConfigPresets(
   let config = {};
   // First, merge all the preset configs from left to right
   if (inputConfig.extends && inputConfig.extends.length) {
-    logger.debug('Found presets');
+    if (existingPresets.length === 0) {
+      logger.info('Found presets');
+    }
     for (const preset of inputConfig.extends) {
       // istanbul ignore if
       if (existingPresets.indexOf(preset) !== -1) {
         logger.warn(`Already seen preset ${preset} in ${existingPresets}`);
       } else {
-        logger.debug(`Resolving preset "${preset}"`);
+        logger.trace(`Resolving preset "${preset}"`);
         const presetConfig = await resolveConfigPresets(
           await getPreset(preset, logger),
           logger,
@@ -138,7 +140,7 @@ function parsePreset(input) {
 }
 
 async function getPreset(preset, logger) {
-  logger.debug(`getPreset(${preset})`);
+  logger.trace(`getPreset(${preset})`);
   const { packageName, presetName, params } = parsePreset(preset);
   let presetConfig;
   try {
@@ -167,7 +169,7 @@ async function getPreset(preset, logger) {
     }
     presetConfig = replaceArgs(presetConfig, argMapping);
   }
-  logger.debug({ presetConfig }, `Applied params to preset ${preset}`);
+  logger.trace({ presetConfig }, `Applied params to preset ${preset}`);
   const presetKeys = Object.keys(presetConfig);
   if (
     presetKeys.length === 2 &&

lib/workers/repository/apis.js

@@ -238,7 +238,7 @@ async function mergeRenovateJson(config, branchName) {
 async function detectPackageFiles(input) {
   const config = { ...input };
   const { logger } = config;
-  logger.trace({ config }, 'detectPackageFiles');
+  logger.debug({ config }, 'detectPackageFiles');
   config.types = {};
   if (config.npm.enabled !== false) {
     config.packageFiles = await config.api.findFilePaths('package.json');

lib/workers/repository/upgrades.js

@@ -21,7 +21,9 @@ async function determineRepoUpgrades(config) {
   }
   let upgrades = [];
   // Iterate through repositories sequentially
-  for (let index = 0; index < config.packageFiles.length; index += 1) {
+  let index = 0;
+  for (const packageFile of config.packageFiles) {
+    logger.trace({ packageFile }, 'Getting packageFile config');
     const packageFileConfig = module.exports.getPackageFileConfig(
       config,
       index
@@ -45,6 +47,7 @@ async function determineRepoUpgrades(config) {
         await packageFileWorker.renovateDockerfile(packageFileConfig)
       );
     }
+    index += 1;
   }
   logger.info(
     { seconds: convertHrTime(process.hrtime(startTime)).seconds },