Skip to content
Snippets Groups Projects
Commit 530f537b authored by Rhys Arkins's avatar Rhys Arkins
Browse files

feat(npm)!: disable rollbackPrs for npm by default (#21970)

BREAKING CHANGE: Rollback PRs will no longer be enabled by default for npm (they are now disabled by default for all managers)
parent bc693f20
Branches
No related tags found
No related merge requests found
...@@ -3288,9 +3288,8 @@ There are times when a dependency version in use by a project gets removed from ...@@ -3288,9 +3288,8 @@ There are times when a dependency version in use by a project gets removed from
For some registries, existing releases or even whole packages can be removed or "yanked" at any time, while for some registries only very new or unused releases can be removed. For some registries, existing releases or even whole packages can be removed or "yanked" at any time, while for some registries only very new or unused releases can be removed.
Renovate's "rollback" feature exists to propose a downgrade to the next-highest release if the current release is no longer found in the registry. Renovate's "rollback" feature exists to propose a downgrade to the next-highest release if the current release is no longer found in the registry.
Renovate does not create these rollback PRs by default, with one exception: npm packages get a rollback PR if needed. Renovate does not create these rollback PRs by default, so this functionality needs to be opted-into.
We recommend you do this selectively with `packageRules` and not globally.
You can configure the `rollbackPrs` property globally, per-language, or per-package to override the default behavior.
## ruby ## ruby
......
...@@ -91,7 +91,6 @@ describe('config/index', () => { ...@@ -91,7 +91,6 @@ describe('config/index', () => {
const config = getManagerConfig(parentConfig, 'npm'); const config = getManagerConfig(parentConfig, 'npm');
expect(config).toContainEntries([ expect(config).toContainEntries([
['fileMatch', ['(^|/)package\\.json$']], ['fileMatch', ['(^|/)package\\.json$']],
['rollbackPrs', true],
]); ]);
expect(getManagerConfig(parentConfig, 'html')).toContainEntries([ expect(getManagerConfig(parentConfig, 'html')).toContainEntries([
['fileMatch', ['\\.html?$']], ['fileMatch', ['\\.html?$']],
......
...@@ -17,7 +17,6 @@ export const supportsLockFileMaintenance = true; ...@@ -17,7 +17,6 @@ export const supportsLockFileMaintenance = true;
export const defaultConfig = { export const defaultConfig = {
fileMatch: ['(^|/)package\\.json$'], fileMatch: ['(^|/)package\\.json$'],
rollbackPrs: true,
versioning: npmVersioning.id, versioning: npmVersioning.id,
digest: { digest: {
prBodyDefinitions: { prBodyDefinitions: {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment