Skip to content
Snippets Groups Projects
Commit 4a43ebce authored by Michael Kriese's avatar Michael Kriese Committed by Rhys Arkins
Browse files

fix(logging): replace password in auth gotOptions (#4108)

parent 642deb0b
No related branches found
No related tags found
No related merge requests found
...@@ -15,7 +15,14 @@ export default function errSerializer(err) { ...@@ -15,7 +15,14 @@ export default function errSerializer(err) {
if (err.stack) { if (err.stack) {
response.stack = err.stack; response.stack = err.stack;
} }
if (err.gotOptions && err.gotOptions.headers) { if (response.gotOptions) {
if (is.string(response.gotOptions.auth)) {
response.gotOptions.auth = response.gotOptions.auth.replace(
/:.*/,
':***********'
);
}
if (err.gotOptions.headers) {
const redactedHeaders = [ const redactedHeaders = [
'authorization', 'authorization',
'private-header', 'private-header',
...@@ -27,6 +34,7 @@ export default function errSerializer(err) { ...@@ -27,6 +34,7 @@ export default function errSerializer(err) {
} }
}); });
} }
}
const redactedFields = ['message', 'stack', 'stdout', 'stderr']; const redactedFields = ['message', 'stack', 'stdout', 'stderr'];
for (const field of redactedFields) { for (const field of redactedFields) {
if (is.string(response[field])) { if (is.string(response[field])) {
......
...@@ -6,6 +6,7 @@ Object { ...@@ -6,6 +6,7 @@ Object {
"b": 2, "b": 2,
"body": "some response body", "body": "some response body",
"gotOptions": Object { "gotOptions": Object {
"auth": "test:***********",
"headers": Object { "headers": Object {
"authorization": "** redacted **", "authorization": "** redacted **",
}, },
......
...@@ -13,6 +13,7 @@ describe('logger/err-serializer', () => { ...@@ -13,6 +13,7 @@ describe('logger/err-serializer', () => {
headers: { headers: {
authorization: 'Bearer abc', authorization: 'Bearer abc',
}, },
auth: 'test:token',
}, },
}; };
expect(configSerializer(err)).toMatchSnapshot(); expect(configSerializer(err)).toMatchSnapshot();
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment