refactor: purl use subpath for lookupType

lib/manager/bazel/extract.js

@@ -128,7 +128,7 @@ function extractPackageFile(content) {
       dep.depName = depName;
       dep.repo = parsedUrl.repo;
       dep.currentValue = parsedUrl.currentValue;
-      dep.purl = 'pkg:github/' + dep.repo + '?lookupType=releases';
+      dep.purl = 'pkg:github/' + dep.repo + '#releases';
       deps.push(dep);
     } else {
       logger.info(

lib/util/purl.js

@@ -41,10 +41,6 @@ function parse(input) {
       const [key, val] = qualifier.split('=');
       res.qualifiers[key] = val;
     });
-    if (res.qualifiers.lookupType) {
-      res.lookupType = res.qualifiers.lookupType;
-      delete res.qualifiers.lookupType;
-    }
     if (res.qualifiers.repository_url) {
       res.repositoryUrls = res.qualifiers.repository_url.split(',');
       delete res.qualifiers.repository_url;
@@ -52,6 +48,10 @@ function parse(input) {
   } else {
     res.qualifiers = {};
   }
+  if (res.subpath) {
+    res.lookupType = res.subpath;
+    delete res.subpath;
+  }
   delete res.namespace;
   delete res.name;
   delete res.version; // we don't use it

test/datasource/github.spec.js

@@ -71,7 +71,7 @@ describe('datasource/github', () => {
       ];
       ghGot.mockReturnValueOnce({ headers: {}, body });
       const res = await datasource.getPkgReleases({
-        purl: 'pkg:github/some/dep?lookupType=releases',
+        purl: 'pkg:github/some/dep#releases',
       });
       expect(res).toMatchSnapshot();
       expect(res.releases).toHaveLength(2);

test/manager/bazel/__snapshots__/extract.spec.js.snap

@@ -90,7 +90,7 @@ Array [
 ",
     "depName": "io_bazel_rules_go",
     "depType": "http_archive",
-    "purl": "pkg:github/bazelbuild/rules_go?lookupType=releases",
+    "purl": "pkg:github/bazelbuild/rules_go#releases",
     "repo": "bazelbuild/rules_go",
   },
   Object {
@@ -107,7 +107,7 @@ Array [
 ",
     "depName": "bazel_skylib",
     "depType": "http_archive",
-    "purl": "pkg:github/bazelbuild/bazel-skylib?lookupType=releases",
+    "purl": "pkg:github/bazelbuild/bazel-skylib#releases",
     "repo": "bazelbuild/bazel-skylib",
   },
 ]

test/util/__snapshots__/purl.spec.js.snap

 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`util/purl parse() parses github with lookupType 1`] = `
+exports[`util/purl parse() parses github with subpath/lookupType 1`] = `
 Object {
   "datasource": "github",
   "lookupName": "abc/def",
@@ -46,18 +46,6 @@ Object {
 }
 `;
 
-exports[`util/purl parse() parses npm with version and 2 qualifiers and subpath 1`] = `
-Object {
-  "datasource": "npm",
-  "lookupName": "foo",
-  "qualifiers": Object {
-    "a": "b",
-    "c": "d",
-  },
-  "subpath": "stop",
-}
-`;
-
 exports[`util/purl parse() parses repository_url qualifier 1`] = `
 Object {
   "datasource": "maven",

test/util/purl.spec.js

@@ -23,11 +23,8 @@ describe('util/purl', () => {
     it('parses npm with version and 2 qualifiers', () => {
       expect(parse('pkg:npm/foo@1.0.0?a=b&c=d')).toMatchSnapshot();
     });
-    it('parses npm with version and 2 qualifiers and subpath', () => {
-      expect(parse('pkg:npm/foo@1.0.0?a=b&c=d#stop')).toMatchSnapshot();
-    });
-    it('parses github with lookupType', () => {
-      expect(parse('pkg:github/abc/def?lookupType=releases')).toMatchSnapshot();
+    it('parses github with subpath/lookupType', () => {
+      expect(parse('pkg:github/abc/def#releases')).toMatchSnapshot();
     });
     it('parses repository_url qualifier', () => {
       expect(