Skip to content
Snippets Groups Projects
Unverified Commit 369d9273 authored by Sergei Zharinov's avatar Sergei Zharinov Committed by GitHub
Browse files

fix(rubygems): Don't throw on metadata errors (#23224)

parent e1ab6a72
No related branches found
No related tags found
No related merge requests found
...@@ -192,7 +192,7 @@ describe('modules/datasource/rubygems/metadata-cache', () => { ...@@ -192,7 +192,7 @@ describe('modules/datasource/rubygems/metadata-cache', () => {
}); });
}); });
it('throws on unknown error', async () => { it('returns fallback result on unknown error', async () => {
const cache = new MetadataCache(new Http('test')); const cache = new MetadataCache(new Http('test'));
httpMock httpMock
...@@ -201,9 +201,14 @@ describe('modules/datasource/rubygems/metadata-cache', () => { ...@@ -201,9 +201,14 @@ describe('modules/datasource/rubygems/metadata-cache', () => {
.reply(500); .reply(500);
const versions = ['1', '2', '3']; const versions = ['1', '2', '3'];
const res = await cache.getRelease(
'https://rubygems.org',
'foobar',
versions
);
await expect( expect(res).toEqual({
cache.getRelease('https://rubygems.org', 'foobar', versions) releases: [{ version: '1' }, { version: '2' }, { version: '3' }],
).rejects.toThrow(); });
}); });
}); });
import hasha from 'hasha'; import hasha from 'hasha';
import { logger } from '../../../logger';
import * as packageCache from '../../../util/cache/package'; import * as packageCache from '../../../util/cache/package';
import { Http, HttpError } from '../../../util/http'; import type { Http } from '../../../util/http';
import { joinUrlParts } from '../../../util/url'; import { joinUrlParts } from '../../../util/url';
import type { ReleaseResult } from '../types'; import type { ReleaseResult } from '../types';
import { GemMetadata, GemVersions } from './schema'; import { GemMetadata, GemVersions } from './schema';
...@@ -62,12 +63,9 @@ export class MetadataCache { ...@@ -62,12 +63,9 @@ export class MetadataCache {
); );
return data; return data;
} catch (err) { } catch (err) {
if (err instanceof HttpError && err.response?.statusCode === 404) { logger.debug({ err }, 'Rubygems: failed to fetch metadata');
const releases = versions.map((version) => ({ version })); const releases = versions.map((version) => ({ version }));
return { releases }; return { releases };
} }
throw err;
}
} }
} }
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment