Relax some shellcheck tests and fix remaining issues

deploy/base/ros_entrypoint.bash

@@ -2,5 +2,6 @@
 set -e
 
 # setup application environment
+# shellcheck disable=SC1091
 source "/root/catkin_ws/install/setup.bash"
 exec "$@"

scripts/ci_run_entry_points.sh

 #!/bin/bash
 
-echo Looking up and executing user entry scripts in: $1
+echo Looking up and executing user entry scripts in: "$1"
 
-find -L $1 -name ci_entry_script.bash -exec bash -c 'echo Running entry script from $(basename $(dirname {})) ; {} ' \;
+find -L "$1" -name ci_entry_script.bash -exec bash -c 'echo Running entry script from $(basename $(dirname $1)) ; $1 ' _ {} \;
 
 echo Finalized running the user entry scripts

scripts/roslaunch_test_generator.sh

 #!/usr/bin/env bash
 
-for foo in $(find $(pwd) -name "package.xml") ; do
-  package_name=$(basename $(realpath $(dirname $foo)))
-  echo Entering package: $package_name
-  cd $(realpath $(dirname $foo))
-  if [[ -n $(grep -i "roslaunch_add_file_check" CMakeLists.txt) ]] ; then
-    echo Package $package_name already has roslaunch_add_file_check - skipping
+# shellcheck disable=SC2044
+for foo in $(find "$(pwd)" -name "package.xml") ; do
+  package_name=$(basename "$(realpath "$(dirname "$foo")")")
+  echo Entering package: "$package_name"
+  cd "$(realpath "$(dirname "$foo")")" || exit
+  if grep -q -i "roslaunch_add_file_check" CMakeLists.txt; then
+    echo Package "$package_name" already has roslaunch_add_file_check - skipping
   else
     if [[ -n $(find . -type f -name "*.launch") ]] ; then
-      echo Adding roslaunch_add_file_check to $package_name
+      echo Adding roslaunch_add_file_check to "$package_name"
 cat <<EOT >> CMakeLists.txt
 
 ## WARNING: automatically generated code; can be (and probably is) very buggy