From 2c21e985f8adc8096866742e7e60290edca2a9c7 Mon Sep 17 00:00:00 2001
From: Jon Azpiazu <jon.azpiazu@tecnalia.com>
Date: Tue, 9 Nov 2021 10:37:35 +0100
Subject: [PATCH] Minor style fixes to script

---
 scripts/enforce_labels.bash | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/scripts/enforce_labels.bash b/scripts/enforce_labels.bash
index 056296b..26f8dbd 100644
--- a/scripts/enforce_labels.bash
+++ b/scripts/enforce_labels.bash
@@ -1,16 +1,21 @@
 #!/bin/bash
 
+if [ "$#" -ne 1 ]; then
+    echo "Usage: $0 IMAGE_NAME"
+    exit 1
+fi
+
 image_name="$1"
 
 declare -A enforced_labels=( ["com.jfrog.artifactory.retention.maxCount"]="10" ["com.jfrog.artifactory.retention.maxDays"]="7")
 
-if ! docker inspect --type=image $1 > /dev/null ; then 
+if ! docker inspect --type=image "$1" > /dev/null ; then 
     echo "Error: image does not exist"
     exit 0
 fi
 
 for label in "${!enforced_labels[@]}" ; do     
-    if ! docker inspect -f "{{json .Config.Labels }}" $image_name | jq -e '.['\"$label\"']' ; then 
+    if ! docker inspect -f "{{json .Config.Labels }}" "$image_name" | jq -e '.['\"$label\"']' ; then 
         echo "Key not found" 
         echo "$label = ${enforced_labels[$label]}"
         label_args+=" --label $label=\"${enforced_labels[$label]}\""
@@ -19,5 +24,5 @@ done
 
 if [ -v label_args ]; then 
     run_command="echo \"FROM $image_name\" | docker build $label_args -t $image_name -"
-    eval "$run_command"
+    echo "$run_command"
 fi
-- 
GitLab