From 0cba1e9687515529c7d28bc88671e7ff3f27d2a6 Mon Sep 17 00:00:00 2001
From: Miguel Prada <miguel.prada@tecnalia.com>
Date: Fri, 17 May 2019 13:10:18 +0200
Subject: [PATCH] Require Dockerfile and shellcheck jobs to succeed

YAML is still allowed to fail because there's a pending problem in our custom
rosdep definition file.
---
 .gitlab-ci.yml | 2 --
 1 file changed, 2 deletions(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index c0d5873..b0fe898 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -1,7 +1,6 @@
 shellcheck:
   image: koalaman/shellcheck-alpine
   script: 'shellcheck deploy/base/ros_entrypoint.bash scripts/*sh'
-  allow_failure: yes
 
 # The ignored rules in hadolint checks are
 # DL3006 Always tag the version of an image explicitly
@@ -17,7 +16,6 @@ dockerfiles:
     - hadolint --ignore DL3006 --ignore DL3008 deploy/base/Dockerfile || RET=1
     - hadolint --ignore DL3006 --ignore DL3008 deploy/dev/Dockerfile || RET=1
     - exit $RET
-  allow_failure: yes
 
 yamllint:
   image: sdesbure/yamllint
-- 
GitLab