From 912e0f39d0be69fd9ec6d9111b8a0e682e20cdca Mon Sep 17 00:00:00 2001
From: Kiran Patel <kiranpatel11@gmail.com>
Date: Wed, 19 Oct 2022 22:59:26 +0000
Subject: [PATCH] fix: kicker.json and README for dependency-check and
forbid-snapshot-dependencies jobs
---
README.md | 2 +-
kicker.json | 9 ++-------
2 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/README.md b/README.md
index 182a245..0f2b3d1 100644
--- a/README.md
+++ b/README.md
@@ -107,8 +107,8 @@ It is bound to the `test` stage, and uses the following variables:
| Name | description | default value |
| --------------------- | -------------------------------------- | ----------------- |
-| `MAVEN_DEPENDENCY_CHECK_ARGS` | Maven arguments for Dependency Check job | `org.owasp:dependency-check-maven:check -DretireJsAnalyzerEnabled=false -DassemblyAnalyzerEnabled=false` |
| `MAVEN_DEPENDENCY_CHECK_DISABLED` | Set to `true` to disable this job | _none_ |
+| `MAVEN_DEPENDENCY_CHECK_ARGS` | Maven arguments for Dependency Check job | `org.owasp:dependency-check-maven:check -DretireJsAnalyzerEnabled=false -DassemblyAnalyzerEnabled=false` |
A Dependency Check is a quite long operation and therefore the job is configured to be ran __manually__ by default.
diff --git a/kicker.json b/kicker.json
index 3867e81..457e107 100644
--- a/kicker.json
+++ b/kicker.json
@@ -84,6 +84,7 @@
"id": "dependency-check",
"name": "Dependency-Check",
"description": "[Dependency-Check](https://jeremylong.github.io/DependencyCheck/dependency-check-maven/configuration.html) analysis",
+ "disable_with": "MAVEN_DEPENDENCY_CHECK_DISABLED",
"variables": [
{
"name": "MAVEN_DEPENDENCY_CHECK_ARGS",
@@ -97,13 +98,7 @@
"id": "forbid-snapshot-dependencies",
"name": "Snapshot dependencies verification",
"description": "This job verifies your project has no _snapshot_ dependencies. Failure is allowed in feature branches.",
- "variables": [
- {
- "name": "MVN_FORBID_SNAPSHOT_DEPENDENCIES_DISABLED",
- "description": "Disable the job",
- "type": "boolean"
- }
- ]
+ "disable_with": "MVN_FORBID_SNAPSHOT_DEPENDENCIES_DISABLED"
},
{
"id": "publish",
--
GitLab