From b9f783b52de5fcdf9efc068e975f34ba0b7ddea6 Mon Sep 17 00:00:00 2001
From: Rhys Arkins <rhys@arkins.net>
Date: Wed, 19 Oct 2022 10:27:03 +0200
Subject: [PATCH] fix: ignoreScripts default (#18403)
Changes ignoreScripts defaulit to be `true`.
Closes #18173
BREAKING CHANGE: ignoreScripts now default to true. If allowScripts=true in global config, ignoreScripts must be set to false in repo config if you want all repos to run scripts.
---
lib/config/options/index.ts | 4 ++--
lib/modules/manager/npm/post-update/lerna.ts | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/config/options/index.ts b/lib/config/options/index.ts
index 8b0221ad6f..853c61fee9 100644
--- a/lib/config/options/index.ts
+++ b/lib/config/options/index.ts
@@ -625,9 +625,9 @@ const options: RenovateOptions[] = [
{
name: 'ignoreScripts',
description:
- 'Set this to `true` if `allowScripts=true` but you wish to skip running scripts when updating lock files.',
+ 'Set this to `false` if `allowScripts=true` and you wish to run scripts when updating lock files.',
type: 'boolean',
- default: false,
+ default: true,
supportedManagers: ['npm', 'composer'],
},
{
diff --git a/lib/modules/manager/npm/post-update/lerna.ts b/lib/modules/manager/npm/post-update/lerna.ts
index 9120e3b45d..31747b8fbf 100644
--- a/lib/modules/manager/npm/post-update/lerna.ts
+++ b/lib/modules/manager/npm/post-update/lerna.ts
@@ -79,7 +79,7 @@ export async function generateLockFiles(
return { error: false };
}
let lernaCommand = `lerna bootstrap --no-ci --ignore-scripts -- `;
- if (GlobalConfig.get('allowScripts') && config.ignoreScripts !== false) {
+ if (GlobalConfig.get('allowScripts') && !config.ignoreScripts) {
cmdOptions = cmdOptions.replace('--ignore-scripts ', '');
lernaCommand = lernaCommand.replace('--ignore-scripts ', '');
}
--
GitLab