From 2e173c3539c28cfd03c29b49272a01971a5fd37b Mon Sep 17 00:00:00 2001
From: Rhys Arkins <rhys@arkins.net>
Date: Thu, 29 Mar 2018 07:07:56 +0200
Subject: [PATCH] fix: better fix for undefined new docker digest
---
lib/manager/docker/package.js | 8 +++++---
test/manager/docker/__snapshots__/package.spec.js.snap | 2 +-
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/lib/manager/docker/package.js b/lib/manager/docker/package.js
index 773adb597e..2e1fa32996 100644
--- a/lib/manager/docker/package.js
+++ b/lib/manager/docker/package.js
@@ -148,13 +148,15 @@ async function getPackageUpdates(config) {
config.depName,
upgrade.newTag
);
- if (!upgrade.newDigest) {
+ if (upgrade.newDigest) {
+ upgrade.newFrom += `@${upgrade.newDigest}`;
+ } else {
logger.warn(
{ dockerRegistry, depName, tag: upgrade.newTag },
'Dockerfile no digest'
);
+ upgrade.newDigest = undefined;
}
- upgrade.newFrom += `@${upgrade.newDigest}`;
}
if (newVersionMajor > currentMajor) {
upgrade.type = 'major';
@@ -170,7 +172,7 @@ async function getPackageUpdates(config) {
);
}
}
- return upgrades.filter(u => u.newDigest !== null);
+ return upgrades;
}
function isStable(tag, unstablePattern) {
diff --git a/test/manager/docker/__snapshots__/package.spec.js.snap b/test/manager/docker/__snapshots__/package.spec.js.snap
index f891a37523..abdde75f93 100644
--- a/test/manager/docker/__snapshots__/package.spec.js.snap
+++ b/test/manager/docker/__snapshots__/package.spec.js.snap
@@ -14,7 +14,7 @@ Array [
"isMinor": true,
"newDepTag": "some-dep:1.1.0-something",
"newDigest": undefined,
- "newFrom": "some-dep:1.1.0-something@undefined",
+ "newFrom": "some-dep:1.1.0-something",
"newTag": "1.1.0-something",
"newVersion": "1.1.0-something",
"newVersionMajor": "1",
--
GitLab